Re: [AppArmor 01/41] Pass struct vfsmount to the inode_create LSM hook

On Thu, Apr 12, 2007 at 02:08:10AM -0700, [email protected] wrote:
> This is needed for computing pathnames in the AppArmor LSM.

Which is an argument against said LSM in current form.


> -	error = security_inode_create(dir, dentry, mode);
> +	error = security_inode_create(dir, dentry, nd ? nd->mnt : NULL, mode);

is a clear sign that interface is wrong.  Leaving aside the general
idiocy of "we prohibit to do something with file if mounted here,
but if there's another mountpoint, well, we just miss", an API of that
kind is just plain wrong.  Either you can live without seeing vfsmount
in that method (in which case you shouldn't pass it at all), or you
have a hole.

NACK.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [AppArmor 01/41] Pass struct vfsmount to the inode_create LSM hook
    • From: Andreas Gruenbacher <[email protected]>

• References:
  • [AppArmor 00/41] AppArmor security module overview
    • From: [email protected]
  • [AppArmor 01/41] Pass struct vfsmount to the inode_create LSM hook
    • From: [email protected]

• Prev by Date: Re: [AppArmor 03/41] Remove redundant check from proc_sys_setattr()
• Next by Date: Re: [AppArmor 38/41] AppArmor: Module and LSM hooks
• Previous by thread: Re: [nameidata 2/2] Pass no useless nameidata to the create, lookup, and permission IOPs
• Next by thread: Re: [AppArmor 01/41] Pass struct vfsmount to the inode_create LSM hook
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]