Re: [AppArmor 03/41] Remove redundant check from proc_sys_setattr()

On Thu, 12 Apr 2007 02:08:12 -0700
[email protected] wrote:

> notify_change() already calls security_inode_setattr() before
> calling iop->setattr.

This is a behaviour change on all of these and limits some behaviour of
existing established security modules

When inode_change_ok is called it has side effects. This includes
clearing the SGID bit on attribute changes caused by chmod. If you make
this change the results of some rulesets may be different before or
after the change is made.

I'm not saying the change is wrong but it does change behaviour so that
needs looking at closely (ditto all other attribute twiddles)

Alan



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [AppArmor 00/41] AppArmor security module overview
  - From: [email protected]
- [AppArmor 03/41] Remove redundant check from proc_sys_setattr()
  - From: [email protected]

Prev by Date: Re: [AppArmor 01/41] Pass struct vfsmount to the inode_create LSM hook
Next by Date: Re: [AppArmor 01/41] Pass struct vfsmount to the inode_create LSM hook
Previous by thread: [AppArmor 03/41] Remove redundant check from proc_sys_setattr()
Next by thread: [AppArmor 25/41] Add a struct vfsmount parameter to vfs_getxattr()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]