From: "Waskiewicz Jr, Peter P" <[email protected]>
Date: Mon, 9 Apr 2007 13:43:11 -0700
> True, but the assignment for "dev" above also casts this void * to
> struct net_device *:
>
> dev = (struct net_device *)
> (((long)p + NETDEV_ALIGN_CONST) & ~NETDEV_ALIGN_CONST);
> dev->padded = (char *)dev - (char *)p;
>
> Shall I remove my cast?
I think so. Casts tend to be red flags during patch review,
so don't add them when not necessary and let's remove the
unnecessary ones too.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
