Re: [patch] high-res timers: UP resume fix

On Sat, 2007-04-07 at 11:47 +0200, Ingo Molnar wrote:
> * Rafael J. Wysocki <[email protected]> wrote:
> 
> > > We do in on_each_cpu() unconditionally. I missed that.
> > 
> > BTW, the on_each_cpu() in clock_was_set() is unnecessary, because 
> > timekeeping_resume() is always run on one CPU.
> 
> yes - but that's not the only place where we do clock_was_set(), and the 
> on_each_cpu() is necessary in every other case. So i think the right 
> solution was the patch i did: to split the resume functionality from the 
> clock_was_set() functionality.

Right, I reused it and just did not notice, that interrupts are enabled
unconditionally in on_each_cpu().

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [patch] high-res timers: UP resume fix
    • From: Ingo Molnar <[email protected]>
  • Re: [patch] high-res timers: UP resume fix
    • From: Thomas Gleixner <[email protected]>
  • Re: [patch] high-res timers: UP resume fix
    • From: "Rafael J. Wysocki" <[email protected]>
  • Re: [patch] high-res timers: UP resume fix
    • From: Ingo Molnar <[email protected]>

• Prev by Date: Re: [patch] high-res timers: UP resume fix
• Next by Date: Re: [patch] high-res timers: resume fix
• Previous by thread: Re: [patch] high-res timers: UP resume fix
• Next by thread: Re: [patch] high-res timers: UP resume fix
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]