Re: [2.6 patch] the scheduled -EINVAL for invalid timevals in setitimer

On Fri, 2007-04-06 at 12:20 +0200, Adrian Bunk wrote:
> As scheduled, do_setitimer() now returns -EINVAL for invalid timeval.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Ha, you beat me by a minute :)

> -	check_itimerval(value);
> +	if (unlikely(!timeval_valid(&value->it_value) || !timeval_valid(&value->it_interval)))
> +		return -EINVAL;
>  

Please make this:

+       if (!timeval_valid(&value->it_value) ||
+           !timeval_valid(&value->it_interval))
+               return -EINVAL;

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [2.6 patch] the scheduled -EINVAL for invalid timevals in setitimer
    • From: Adrian Bunk <[email protected]>

• References:
  • [2.6 patch] the scheduled -EINVAL for invalid timevals in setitimer
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: [PATCH 2.6.21-rc6] [netfilter] early_drop imrovement
• Next by Date: Re: [PATCH] Define EFLAGS_IF
• Previous by thread: [2.6 patch] the scheduled -EINVAL for invalid timevals in setitimer
• Next by thread: [2.6 patch] the scheduled -EINVAL for invalid timevals in setitimer
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]