Re: [PATCH 002 of 4] md: Make 'repair' actually work for raid1.

On Tue, 23 Jan 2007 11:26:52 +1100
NeilBrown <[email protected]> wrote:

> +					for (j = 0; j < vcnt ; j++)
> +						memcpy(page_address(sbio->bi_io_vec[j].bv_page),
> +						       page_address(pbio->bi_io_vec[j].bv_page),
> +						       PAGE_SIZE);

I trust these BIOs are known to only contain suitably-allocated, MD-private
pages?  Because if these pages can be user pages then this change is
spectacularly buggy ;)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 002 of 4] md: Make 'repair' actually work for raid1.
  - From: Neil Brown <[email protected]>

References:
- [PATCH 000 of 4] md: Introduction - Assorted bugfixes
  - From: NeilBrown <[email protected]>
- [PATCH 002 of 4] md: Make 'repair' actually work for raid1.
  - From: NeilBrown <[email protected]>

Prev by Date: Re: [PATCH 2.6.20-rc5] Gigaset ISDN driver error handling fixes
Next by Date: Re: [RFC] Limit the size of the pagecache
Previous by thread: [PATCH 002 of 4] md: Make 'repair' actually work for raid1.
Next by thread: Re: [PATCH 002 of 4] md: Make 'repair' actually work for raid1.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]