On Wed, 17 Jan 2007 18:42:13 +0100 (CET)
Tilman Schmidt <[email protected]> wrote:
> + mutex_init(&cs->mutex);
> + mutex_lock(&cs->mutex);
I have vague memories of making rude comments about this a few months ago.
It is very weird to lock a mutex just after intialising it. I mean, if any other
thread can lock this mutex then there's a race. If no other thread can
lock it, then this thread doesn't need to either.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]