On 11/30/06, Robert P. J. Day <[email protected]> wrote:
but there are a few other cases which still contain compound preprocessor directives such as: #if defined(__KERNEL__) || !defined(__GLIBC__) || (__GLIBC__ < 2) having never worked with unifdef before, i guess i was being overly optimistic in thinking that it, if i "unifdef"ed __KERNEL__, it might at least simplify the expression. oh, well ... live and learn.
userspace should be worrying about userspace, so having the socket.h and stat.h pollute the namespace in the non-glibc case is wrong and pretty much prevents any other libc from utilizing these headers sanely unless they set up the __GLIBC__ define themselves (which sucks) -mike
Attachment:
linux-scrub-GLIBC-ifdefs.patch
Description: Binary data
- Follow-Ups:
- Re: [patch] scrub non-__GLIBC__ checks in linux/socket.h and linux/stat.h
- From: Erik Andersen <[email protected]>
- Re: [patch] scrub non-__GLIBC__ checks in linux/socket.h and linux/stat.h
- Prev by Date: Re: [PATCH][2.6.20-rc1-mm1] sparsemem vmem_map optimzed pfn_valid() [0/2]
- Next by Date: Re: 2.6.19 file content corruption on ext3
- Previous by thread: [PATCH] xt_request_find_match
- Next by thread: Re: [patch] scrub non-__GLIBC__ checks in linux/socket.h and linux/stat.h
- Index(es):