On 12/12/06, Adrian Bunk <[email protected]> wrote:
On Wed, Dec 06, 2006 at 06:03:50PM -0500, Mike Frysinger wrote: > there are a plethora of headers that cannot be included straight due > to the usage of __ types (like __u32) without first including > linux/types.h ... so the question is, should all of these headers be > fixed to properly pull in linux/types.h first or are users expected to > "just know" the correct order of headers ? in my mind, pretty much > every header is fair game for straight "#include <header>" usage and > requiring a list of headers to be pulled in properly is ignoring the > problem ... Yes, they should all be fixed to #include <linux/types.h>.
thanks, mondo patch attached :) -mike
Attachment:
linux-include-types-header.patch
Description: Binary data
- Follow-Ups:
- Prev by Date: Re: Binary Drivers
- Next by Date: Re: r8169 on n2100 (was Re: r8169 mac address change (was Re: [0/3] 2.6.19-rc2: known regressions))
- Previous by thread: [PATCH 1/5] Char: isicom, fix locking in isr
- Next by thread: Re: [patch] include linux/types.h in a bunch of header files for usage with install_headers
- Index(es):