Re: sysfs file creation result nightmare

On Sat, 16 Dec 2006 07:16:13 +1100
Benjamin Herrenschmidt <[email protected]> wrote:

> > Beware that sysfs_remove_bin_file() will complain loudly if you later
> > attempt to delete that file that was never created.
> 
> That's another problem... what is a driver that creates 15 files
> supposed to do ? Have 15 booleans to remember which files where
> successfully created and then test all of them on cleanup ? That sounds
> like even more bloat to me...

That's the sort of thing which should be done inside sysfs_create_group()
and sysfs_remove_group().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: sysfs file creation result nightmare
    • From: Greg KH <[email protected]>

• References:
  • sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings)
    • From: Benjamin Herrenschmidt <[email protected]>
  • Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings)
    • From: Andrew Morton <[email protected]>
  • Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings)
    • From: Olivier Galibert <[email protected]>
  • Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings)
    • From: Andrew Morton <[email protected]>
  • Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings)
    • From: Olivier Galibert <[email protected]>
  • Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings)
    • From: Andrew Morton <[email protected]>
  • Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings)
    • From: Benjamin Herrenschmidt <[email protected]>
  • Re: sysfs file creation result nightmare
    • From: Jean Delvare <[email protected]>
  • Re: sysfs file creation result nightmare
    • From: Benjamin Herrenschmidt <[email protected]>

• Prev by Date: Re: [PATCH/v2] CodingStyle updates
• Next by Date: Re: r8169 on n2100 (was Re: r8169 mac address change (was Re: [0/3] 2.6.19-rc2: known regressions))
• Previous by thread: Re: sysfs file creation result nightmare
• Next by thread: Re: sysfs file creation result nightmare
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]