Re: [PATCH 2.6.20-rc1] ib_verbs: Use explicit if-else statements to avoid errors with do-while macros

• To: Ben Collins <[email protected]>
• Subject: Re: [PATCH 2.6.20-rc1] ib_verbs: Use explicit if-else statements to avoid errors with do-while macros
• From: Roland Dreier <[email protected]>
• Date: Wed, 13 Dec 2006 22:16:35 -0800
• Authentication-results: sj-dkim-1; [email protected]; dkim=pass ( sig from cisco.com/sjdkim1002 verified; );
• Cc: Linus Torvalds <[email protected]>, [email protected]
• Dkim-signature: v=0.5; a=rsa-sha256; q=dns/txt; l=742; t=1166076997; x=1166940997; c=relaxed/simple; s=sjdkim1002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; [email protected]; z=From:=20Roland=20Dreier=20<[email protected]> |Subject:=20Re=3A=20[PATCH=202.6.20-rc1]=20ib_verbs=3A=20Use=20explicit=2 0if-else=20statements=20to=20avoid=20errors=20with=20do-while=20macros |Sender:=20; bh=f3SLrq48YOJoulda612OL7VCd/O5xQAhmIakpFwIDEE=; b=YV5VGiAKqke4ar85FrparzWqoyuKNrvsyte3co8FzAM4H60HqTZ//veS2d0l45FC1Q8XjzwT mPJih+RbUwCA5pSAPD1YEoW6KeLNvM+uqJg9d6uke2AIUEHfTob8BkQh;
• In-reply-to: <1166065805.6748.135.camel@gullible> (Ben Collins's message of "Wed, 13 Dec 2006 22:10:05 -0500")
• References: <1166065805.6748.135.camel@gullible>
• Sender: [email protected]
• User-agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.19 (linux)

I see Linus already took this, which is fine... blame me for merging
this without fixing my cross-compile testbed.

Anyway:

 >  static inline int ib_dma_mapping_error(struct ib_device *dev, u64 dma_addr)
 >  {
 > -	return dev->dma_ops ?
 > -		dev->dma_ops->mapping_error(dev, dma_addr) :
 > -		dma_mapping_error(dma_addr);
 > +	if (dev->dma_ops)
 > +		return dev->dma_ops->mapping_error(dev, dma_addr);
 > +	return dma_mapping_error(dma_addr);

This stuff wasn't needed, was it?  It's only the wrappers around void
functions that can't use ?: I would think... surely any trivial macro
replacement for a dma API function that returns a value must evaluate
to something like (0) that is safe to use in this context.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 2.6.20-rc1] ib_verbs: Use explicit if-else statements to avoid errors with do-while macros
    • From: Ben Collins <[email protected]>

• Prev by Date: Re: [patch] Add allowed_affinity to the irq_desc to make it possible to have restricted irqs
• Next by Date: Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]
• Previous by thread: [PATCH 2.6.20-rc1] ib_verbs: Use explicit if-else statements to avoid errors with do-while macros
• Next by thread: Re: [PATCH 2.6.20-rc1] ib_verbs: Use explicit if-else statements to avoid errors with do-while macros
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]