Linus Torvalds wrote:
On Mon, 11 Dec 2006, Andy Whitcroft wrote:I am afraid to report that this second version also fails for me, as you point out CIFS can break us if defined.Olaf, will you admit that the SLES9 code is crap now?Andy, does just replacing the "__initdata" with "const" fix it for you? That should hopefully mean that IN PRACTICE the Linux version string will be the first one to be triggered, if only because init/main.c is linked reasonably early, and all the other "Linux version" strings will hopefully be in the same rodata section.
Yes that does make things 'work' again. This all seems pretty fragile :(.
Sad, sad. We shouldn't need to work around tools that are so _obviously_ broken like this.
-apw - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- 2.6.19-git13: uts banner changes break SLES9 (at least)
- From: Andy Whitcroft <[email protected]>
- Re: 2.6.19-git13: uts banner changes break SLES9 (at least)
- From: Olaf Hering <[email protected]>
- Re: 2.6.19-git13: uts banner changes break SLES9 (at least)
- From: Linus Torvalds <[email protected]>
- Re: 2.6.19-git13: uts banner changes break SLES9 (at least)
- From: Linus Torvalds <[email protected]>
- Re: 2.6.19-git13: uts banner changes break SLES9 (at least)
- From: Olaf Hering <[email protected]>
- Re: 2.6.19-git13: uts banner changes break SLES9 (at least)
- From: Olaf Hering <[email protected]>
- Re: 2.6.19-git13: uts banner changes break SLES9 (at least)
- From: Linus Torvalds <[email protected]>
- Re: 2.6.19-git13: uts banner changes break SLES9 (at least)
- From: Herbert Poetzl <[email protected]>
- Re: 2.6.19-git13: uts banner changes break SLES9 (at least)
- From: Linus Torvalds <[email protected]>
- Re: 2.6.19-git13: uts banner changes break SLES9 (at least)
- From: Andy Whitcroft <[email protected]>
- Re: 2.6.19-git13: uts banner changes break SLES9 (at least)
- From: Linus Torvalds <[email protected]>
- 2.6.19-git13: uts banner changes break SLES9 (at least)
- Prev by Date: RE: [PATCH] i386 add idle notifier (take 2)
- Next by Date: [PATCH] kvm needs menu structure
- Previous by thread: Re: 2.6.19-git13: uts banner changes break SLES9 (at least)
- Next by thread: Re: 2.6.19-git13: uts banner changes break SLES9 (at least)
- Index(es):