Re: 2.6.19-git13: uts banner changes break SLES9 (at least)

[Andy Whitcroft <apw@shadowen.org>]

Linus Torvalds wrote:
> On Mon, 11 Dec 2006, Herbert Poetzl wrote:
> > cool!
> >
> > should definitely work for all 'known' cases
>
> No it doesn't.
>
> Do a
>
> 	git grep '".*Linux version .*"'
>
> on the kernel, and see just how CRAP that "get_kernel_version" test is, 
> and has always been.
>
> But let's hope that CIFS is never compiled into a SLES kernel. Because 
> this isn't worth fixing at that point, and the SLES people should just fix 
> their piece of crap initrd script.
>
> And next time somebody says "random vmlinux binary" to me, I'll blacklist 
> their email address. You shouldn't do initrd for "random binaries". Just 
> pass the release name somewhere (maybe in the name of the binary, for 
> example, and if the name doesn't have a version in it, tough titties).
>
> 		Linus
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

I am afraid to report that this second version also fails for me, as you 
point out CIFS can break us if defined.  In fact we used to get away 
with this on my test system due to ordering magic luck, I presume the 
move to __initdata has triggered this.  Much as I agree that this is 
wrong we are still going to break people with this.

Before:

Module list:	sym53c8xx reiserfs
Kernel version:	2.6.19-git12-autokern1 (powerpc)
Kernel image:	/boot/vmlinuz-autobench
Initrd image:	/boot/initrd-autobench.img.new
Shared libs:	lib/ld-2.3.3.so lib/libc.so.6 lib/libselinux.so.1
Cannot determine dependencies of module sym53c8xx. Is modules.dep up to 
date?
Modules:	
none
5735 blocks

After:

Module list:	sym53c8xx reiserfs
Kernel version:	 (powerpc)
Kernel image:	/boot/vmlinuz-autobench
Initrd image:	/boot/initrd-autobench.img.new
No modules found for kernel

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/