Re: [PATCH] libata: don't initialize sg in ata_exec_internal() if DMA_NONE

Arnd Bergmann wrote:

On Monday 11 December 2006 15:02, Tejun Heo wrote:

 {
        struct scatterlist sg;
+       unsigned int n_elem = 0;

- sg_init_one(&sg, buf, buflen);

+       if (dma_dir != DMA_NONE) {
+               WARN_ON(!buf);
+               sg_init_one(&sg, buf, buflen);
+               n_elem++;
+       }

Ok, looks good as well. I still think we should have the WARN_ON()
in sg_set_buf(), but I can send a separate patch for that to linux-mm.

Please CC me and linux-ide on all libata patches (certainly akpm as well). Andrew picks up most of the libata changes automatically via git from my libata-dev.git#ALL.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] libata: fix oops with sparsemem
    • From: Arnd Bergmann <[email protected]>
  • [PATCH] libata: don't initialize sg in ata_exec_internal() if DMA_NONE
    • From: Tejun Heo <[email protected]>

• Prev by Date: Re: 2.6.19-mm1
• Next by Date: Re: Linux 2.6.19
• Previous by thread: Re: [PATCH] libata: don't initialize sg in ata_exec_internal() if DMA_NONE
• Next by thread: Re: [PATCH] libata: don't initialize sg in ata_exec_internal() if DMA_NONE
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]