Re: cmpxchg() in kernel/workqueue.c breaks things

Andrew Morton <[email protected]> wrote:

> I don't see why the 2.6.19 logic needed changing.
> 
> a) Nobody should be freeing the work_struct itself without running
>    flush_scheduled_work() and
> 
> b) even if the work_struct _did_ get freed, the callback function won't
>    care, because there's nothing in that work_struct which it's interested
>    in.

Erm...  Did you mean that in reply to my suggestion that we don't need to use
cmpxchg()?

We might want to avoid cmpxchg() because it isn't available on all platforms
under all circumstances, and besides I'm not sure it's actually necessary.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: cmpxchg() in kernel/workqueue.c breaks things
  - From: Andrew Morton <[email protected]>

References:
- Re: cmpxchg() in kernel/workqueue.c breaks things
  - From: Andrew Morton <[email protected]>
- cmpxchg() in kernel/workqueue.c breaks things
  - From: David Miller <[email protected]>
- Re: cmpxchg() in kernel/workqueue.c breaks things
  - From: David Howells <[email protected]>

Prev by Date: Re: [2.6 patch] drivers/net/bnx2.c: add an error check
Next by Date: [PATCH] kbuild : Make Fusion MPT selectable from "Device drivers" menu
Previous by thread: Re: cmpxchg() in kernel/workqueue.c breaks things
Next by thread: Re: cmpxchg() in kernel/workqueue.c breaks things
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]