cmpxchg() in kernel/workqueue.c breaks things

David, you have to fix the locking scheme used in kernel/workqueue.c,
you absolutely cannot assume that cmpxchg() is available on all
platforms.  This breaks the build on the platforms that don't
have such an instruction, and no it cannot emulated.

Also, because Alan Cox's machine (zeniv) went down, a few folks such
as Al Viro (CC:'d) had no opportunity to comment on your changes
before they went in.  This mess would have been avoided if Al had a
chance to read over this, in particular since he does cross sparc32
builds he knows that cmpxchg is not available there.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: cmpxchg() in kernel/workqueue.c breaks things
    • From: Russell King <[email protected]>
  • Re: cmpxchg() in kernel/workqueue.c breaks things
    • From: David Howells <[email protected]>
  • Re: cmpxchg() in kernel/workqueue.c breaks things
    • From: David Howells <[email protected]>
  • Re: cmpxchg() in kernel/workqueue.c breaks things
    • From: Al Viro <[email protected]>

• Prev by Date: [PATCH 1/5 -mm] fault-injection: Correct, disambiguate, and reformat documentation.
• Next by Date: [PATCH 2/5 -mm] fault-injection: Use bool-true-false throughout
• Previous by thread: [PATCH 1/5 -mm] fault-injection: Correct, disambiguate, and reformat documentation.
• Next by thread: Re: cmpxchg() in kernel/workqueue.c breaks things
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]