Re: [RFC] rfkill - Add support for input key to control wireless radio

On Sun, 2006-12-03 at 19:36 +0100, Ivo van Doorn wrote:
> +
> +       down(&master->key_sem);
> + 

Hi,

this one seems to be used as a mutex only, please consider using a mutex
instead, as is the default for new code since 2.6.16 or so....

Greetings,
   Arjan van de Ven

-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC] rfkill - Add support for input key to control wireless radio
    • From: Ivo van Doorn <[email protected]>

• References:
  • [RFC] rfkill - Add support for input key to control wireless radio
    • From: Ivo van Doorn <[email protected]>

• Prev by Date: Re: [Cluster-devel] Re: [GFS2] Change argument of gfs2_dinode_out [17/70]
• Next by Date: Re: [RFC] rfkill - Add support for input key to control wireless radio
• Previous by thread: [RFC] rfkill - Add support for input key to control wireless radio
• Next by thread: Re: [RFC] rfkill - Add support for input key to control wireless radio
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]