The reservations tree is an rb_tree not a list, so it's less confusing to use rb_entry() than list_entry() - though they're both just container_of(). Signed-off-by: Hugh Dickins <[email protected]> --- fs/ext2/balloc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- 2.6.19-rc6-mm2/fs/ext2/balloc.c 2006-11-24 08:18:02.000000000 +0000 +++ linux/fs/ext2/balloc.c 2006-11-27 19:28:41.000000000 +0000 @@ -156,7 +156,7 @@ restart: printk("Block Allocation Reservation Windows Map (%s):\n", fn); while (n) { - rsv = list_entry(n, struct ext2_reserve_window_node, rsv_node); + rsv = rb_entry(n, struct ext2_reserve_window_node, rsv_node); if (verbose) printk("reservation window 0x%p " "start: %lu, end: %lu\n", @@ -753,7 +753,7 @@ static int find_next_reservable_window( prev = rsv; next = rb_next(&rsv->rsv_node); - rsv = list_entry(next,struct ext2_reserve_window_node,rsv_node); + rsv = rb_entry(next,struct ext2_reserve_window_node,rsv_node); /* * Reached the last reservation, we can just append to the @@ -995,7 +995,7 @@ static void try_to_extend_reservation(st if (!next) my_rsv->rsv_end += size; else { - next_rsv = list_entry(next, struct ext2_reserve_window_node, rsv_node); + next_rsv = rb_entry(next, struct ext2_reserve_window_node, rsv_node); if ((next_rsv->rsv_start - my_rsv->rsv_end - 1) >= size) my_rsv->rsv_end += size; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- [PATCH 10/12] ext4 balloc: say rb_entry not list_entry
- From: Mingming Cao <[email protected]>
- [PATCH 4/12] ext3 balloc: say rb_entry not list_entry
- From: Mingming Cao <[email protected]>
- Re: [PATCH 5/6] ext2 balloc: say rb_entry not list_entry
- From: Mingming Cao <[email protected]>
- [PATCH 10/12] ext4 balloc: say rb_entry not list_entry
- References:
- 2.6.19-rc5-mm2
- From: Andrew Morton <[email protected]>
- Boot failure with ext2 and initrds
- From: [email protected] (Mel Gorman)
- Re: Boot failure with ext2 and initrds
- From: Hugh Dickins <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Andrew Morton <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Hugh Dickins <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Hugh Dickins <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Andrew Morton <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Mingming Cao <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Andrew Morton <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Mingming Cao <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Andrew Morton <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Mingming Cao <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Andrew Morton <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Hugh Dickins <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Mingming Cao <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Hugh Dickins <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Mingming Cao <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Hugh Dickins <[email protected]>
- 2.6.19-rc5-mm2
- Prev by Date: [PATCH 4/6] ext2 balloc: fix off-by-one against grp_goal
- Next by Date: [PATCH 6/6] ext2 balloc: use io_error label
- Previous by thread: [PATCH 9/12] ext4 balloc: fix off-by-one against rsv_end
- Next by thread: Re: [PATCH 5/6] ext2 balloc: say rb_entry not list_entry
- Index(es):
 |