grp_goal 0 is a genuine goal (unlike -1), so ext2_try_to_allocate_with_rsv should treat it as such. Signed-off-by: Hugh Dickins <[email protected]> --- fs/ext2/balloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 2.6.19-rc6-mm2/fs/ext2/balloc.c 2006-11-24 08:18:02.000000000 +0000 +++ linux/fs/ext2/balloc.c 2006-11-27 19:28:41.000000000 +0000 @@ -1053,7 +1053,7 @@ ext2_try_to_allocate_with_rsv(struct sup } /* * grp_goal is a group relative block number (if there is a goal) - * 0 < grp_goal < EXT2_BLOCKS_PER_GROUP(sb) + * 0 <= grp_goal < EXT2_BLOCKS_PER_GROUP(sb) * first block is a filesystem wide block number * first block is the block number of the first block in this group */ @@ -1089,7 +1089,7 @@ ext2_try_to_allocate_with_rsv(struct sup if (!goal_in_my_reservation(&my_rsv->rsv_window, grp_goal, group, sb)) grp_goal = -1; - } else if (grp_goal > 0) { + } else if (grp_goal >= 0) { int curr = my_rsv->rsv_end - (grp_goal + group_first_block) + 1; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- [PATCH 9/12] ext4 balloc: fix off-by-one against rsv_end
- From: Mingming Cao <[email protected]>
- [PATCH 7/12] ext4 balloc: reset windowsz when full
- From: Mingming Cao <[email protected]>
- [PATCH 3/12] ext3 balloc: fix off-by-one against rsv_end
- From: Mingming Cao <[email protected]>
- [PATCH 1/12] ext3 balloc: reset windowsz when full
- From: Mingming Cao <[email protected]>
- Re: [PATCH 4/6] ext2 balloc: fix off-by-one against grp_goal
- From: Mingming Cao <[email protected]>
- [PATCH 9/12] ext4 balloc: fix off-by-one against rsv_end
- References:
- 2.6.19-rc5-mm2
- From: Andrew Morton <[email protected]>
- Boot failure with ext2 and initrds
- From: [email protected] (Mel Gorman)
- Re: Boot failure with ext2 and initrds
- From: Hugh Dickins <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Andrew Morton <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Hugh Dickins <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Hugh Dickins <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Andrew Morton <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Mingming Cao <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Andrew Morton <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Mingming Cao <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Andrew Morton <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Mingming Cao <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Andrew Morton <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Hugh Dickins <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Mingming Cao <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Hugh Dickins <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Mingming Cao <[email protected]>
- Re: Boot failure with ext2 and initrds
- From: Hugh Dickins <[email protected]>
- 2.6.19-rc5-mm2
- Prev by Date: Re: Entropy Pool Contents
- Next by Date: [PATCH 5/6] ext2 balloc: say rb_entry not list_entry
- Previous by thread: Re: [PATCH 3/6] ext2 balloc: fix off-by-one against rsv_end
- Next by thread: Re: [PATCH 4/6] ext2 balloc: fix off-by-one against grp_goal
- Index(es):
 |