RE: [PATCH] Add IDE mode support for SB600 SATA

["Conke Hu" <conke.hu@amd.com>]

-----Original Message-----
From: Arjan van de Ven [mailto:arjan@infradead.org] 
Sent: Thursday, November 23, 2006 4:06 PM
To: Conke Hu
Cc: linux-kernel@vger.kernel.org; alan@lxorguk.ukuu.org.uk; Andrew Morton; Jeff Garzik
Subject: Re: [PATCH] Add IDE mode support for SB600 SATA

On Thu, 2006-11-23 at 12:20 +0800, Conke Hu wrote:
> ATI SB600 SATA controller supports 4 modes: Legacy IDE, Native IDE, AHCI and RAID. Legacy/Native IDE mode is designed for compatibility with some old OS without AHCI driver but looses SATAII/AHCI features such as NCQ. This patch will make SB600 SATA run in AHCI mode even if it was set as IDE mode by system BIOS.


is this really the right thing? You're overriding a user chosen configuration here.... while that might be justifiable.. it's probably a good idea to at least provide a safety-valve for this one. The user might have made that selection very deliberately.

--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-------------------------------

Hi Arjan,
    In my preivious patch(with the same email title "[PATCH] Add IDE mode support for SB600 SATA"), I provided a config option and kernel users (the "users" here includes kernel developers and linux fans) can use the sata controller as IDE or AHCI, but Andrew did not think that was good idea.

    [Quote from Andrew]
    I doubt if it's appropriate to do all this via ifdefs.  Users don't compile their kernels - others compile them for the users.  We need the one kernel
    binary to support both modes.   Possible?

Andrew means only one mode (i.e. ahci) support is enough, so I've re-writen this patch according to Alan's adavice, see bellow:

    [Quote from Alan Cox]
    That seems fine to me. I would have thought putting the code you have into the quirks.c file as you proposed was the better way to do this, but with the addition of the 
    #if defined (CONFIG_ATA_AHCI) || defined(CONFIG_ATA_AHCI_MODULE)
   
    #endif 
    around it

Hi Alan,
    Today I've sent out 2 patches about the same issue. one patch/solution is providing a config option to support both IDE driver and AHCI driver; another is using ahci driver for all modes. The two patches respectively corresond to two mails with the same title "[PATCH] Add IDE mode support for SB600 SATA", please take a look at both patches for more details.
    Which patch/solution do you think is acceptable? Or is there anything that needs to be improved?


Thank you!
Conke




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/