On Mon, 2006-11-20 at 18:55 +0100, Ingo Molnar wrote:
> Index: linux/kernel/irq/chip.c
> ===================================================================
> --- linux.orig/kernel/irq/chip.c
> +++ linux/kernel/irq/chip.c
> @@ -238,8 +238,10 @@ static inline void mask_ack_irq(struct i
> if (desc->chip->mask_ack)
> desc->chip->mask_ack(irq);
> else {
> - desc->chip->mask(irq);
> - desc->chip->ack(irq);
> + if (desc->chip->mask)
> + desc->chip->mask(irq);
> + if (desc->chip->mask)
> + desc->chip->ack(irq);
> }
> }
Did you mean to check ->mask both times here?
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Ingo Molnar <[email protected]>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Ingo Molnar <[email protected]>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Ingo Molnar <[email protected]>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Sergei Shtylyov <[email protected]>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Ingo Molnar <[email protected]>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Sergei Shtylyov <[email protected]>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Ingo Molnar <[email protected]>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Ingo Molnar <[email protected]>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- Prev by Date: Debugfs : inotify, multiple calls to debugfs_create_file, remove
- Next by Date: Re: xconfig segfault
- Previous by thread: Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- Next by thread: Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- Index(es):
 |