Re: 2.6.19-rc5-mm2

[Reuben Farrelly <reuben-linuxkernel@reub.net>]

Hi,

On 15/11/2006 9:34 PM, Gautham R Shenoy wrote:
> Hi,
>
> On Tue, Nov 14, 2006 at 09:58:29PM +0100, Mattia Dongili wrote:
> > maybe this helps? mostly guessing here, but when cpufreq_userspace is
> > the default governor we may hit this path and leave policy->cur
> > unset.
>
> I doubt if that's causing the problem. My reasons are:

Yes.  I just tried with the one-liner from Mattia as below, and unfortunately it 
made no difference.  The crash was the same..

Unfortunately I didn't get to test out 2.6.19-rc5-mm1 as there was some issue 
with it unable to mount my ext3/raid-1 root (fixed in -rc5-mm2), that I didn't 
have time to get to the bottom of.

So there is a chance that this cpufreq problem is not new to -rc5-mm2.

Reuben


> - Reuben's config shows his system to be a x64_64. So if I am not
>   mistaken, the correct file look for would be 
>   arch/ia64/kernel/cpufreq/acpi-cpufreq.c.
>
> - The fix provided by you deals with the state of a 
>   driver(hardware) specific variable data->cpu_feature while the
>   governors like userspace/performance/powersave/ondemand are 
>   driver(hardware) independent.
>
> Nevertheless, it could be a valid fix for i386 acpi_cpufreq considering
> that policy->cur is not being initialized if 
> data->cpu_feature == ACPI_ADR_SPACE_FIXED_HARDWARE.
>
> Please check with Dave Jones or Venkatesh Pallipadi.
>
> Thanks
> gautham.
>
> > diff --git a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
> > index 18f4715..94e6e86 100644
> > --- a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
> > +++ b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
> > @@ -706,7 +706,7 @@ static int acpi_cpufreq_cpu_init(struct
> >  		break;
> >  	case ACPI_ADR_SPACE_FIXED_HARDWARE:
> >  		acpi_cpufreq_driver.get = get_cur_freq_on_cpu;
> > -		get_cur_freq_on_cpu(cpu);
> > +		policy->cur = get_cur_freq_on_cpu(cpu);
> >  		break;
> >  	default:
> >  		break;
> >
> > --
> > mattia

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/