Re: [PATCH 6/13] BC: kmemsize accounting (core)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/9/06, Kirill Korotaev <[email protected]> wrote:
+#ifdef CONFIG_BEANCOUNTERS
+#define BC_EXTRASIZE   sizeof(struct beancounter *)

Would much prefer you put all beancounter stuff into one #ifdef block
to avoid clutter.

@@ -2579,14 +2635,14 @@ static struct slab *alloc_slabmgmt(struc
        slabp->colouroff = colour_off;
        slabp->s_mem = objp + colour_off;
        slabp->nodeid = nodeid;
+#ifdef CONFIG_BEANCOUNTERS
+       if (cachep->flags & SLAB_BC)
+               memset(slab_bc_ptrs(cachep, slabp), 0,
+                               cachep->num * BC_EXTRASIZE);
+#endif

No #ifdef within functions, please, but instead, make it an static
inline function.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux