Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.

On Wed, 8 Nov 2006 11:13:41 +0900 KAMEZAWA Hiroyuki <[email protected]> wrote:
>
> Ah.. I'm mentioning to this.
> ==
> +			pm[i].node = 0;	/* anything to not match MAX_NUMNODES */
> ==
> Sorry for my bad cut & paste.
>
> It seems that this 0 will be passed to alloc_pages_node().
> alloc_pages_node() doesn't check whether a node is online or not before using
> NODE_DATA().

Actually, it won't.  If you do that assignment, then the nodes parameter
was NULL and you will only call do_pages_stat() and so never call
alloc_pages_node().

--
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/

Attachment: pgpEDQHC271dX.pgp
Description: PGP signature

---

• Follow-Ups:
  • Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.
    • From: KAMEZAWA Hiroyuki <[email protected]>

• References:
  • [PATCH] Fix sys_move_pages when a NULL node list is passed.
    • From: Stephen Rothwell <[email protected]>
  • Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.
    • From: KAMEZAWA Hiroyuki <[email protected]>
  • Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.
    • From: Christoph Lameter <[email protected]>
  • Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.
    • From: KAMEZAWA Hiroyuki <[email protected]>

• Prev by Date: Re: [PATCH 2/3] add dev_to_node()
• Next by Date: Re: [ckrm-tech] [RFC] Resource Management - Infrastructure choices
• Previous by thread: Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.
• Next by thread: Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]