Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.

On Tue, 7 Nov 2006 18:01:11 -0800 (PST)
Christoph Lameter <[email protected]> wrote:

> On Wed, 8 Nov 2006, KAMEZAWA Hiroyuki wrote:
> 
> > >  	pm[nr_pages].node = MAX_NUMNODES;
> > 
> > I think node0 is always online...but this should be
> > 
> > pm[i].node = first_online_node; // /* any online node */
> 
> No it is a marker. The use of any node that is online could lead to a 
> false determination of the endpoint of the list.
> 
Ah.. I'm mentioning to this.
==
+			pm[i].node = 0;	/* anything to not match MAX_NUMNODES */
==
Sorry for my bad cut & paste.

It seems that this 0 will be passed to alloc_pages_node().
alloc_pages_node() doesn't check whether a node is online or not before using 
NODE_DATA().

-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.
    • From: Stephen Rothwell <[email protected]>

• References:
  • [PATCH] Fix sys_move_pages when a NULL node list is passed.
    • From: Stephen Rothwell <[email protected]>
  • Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.
    • From: KAMEZAWA Hiroyuki <[email protected]>
  • Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.
    • From: Christoph Lameter <[email protected]>

• Prev by Date: [patch 4/4] fix the irqbalance quirk for E7320/E7520/E7525
• Next by Date: Re: [GIT PULL] Missing *eof assignment in Alpha's srm_env driver
• Previous by thread: Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.
• Next by thread: Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]