Alberto Alonso wrote:
I have a Pacific Digital qstor card on irq 193. I am using kernel
2.6.17.13 SMP
The error happens every now and then. I have not been able to
figure out any triggers and I can not reproduce it on demand. Today
it happened 3 times within a 40 minutes period.
All disks connected to the card are disabled and I can't do anything
other than a reboot to get them back.
It is reported as follows:
irq 193: nobody cared (try booting with the "irqpoll" option)
<c013e19a> __report_bad_irq+0x2a/0xa0 <c013d970> handle_IRQ_event
+0x30/0x70
<c013e2b0> note_interrupt+0x80/0xf0 <c013da8c> __do_IRQ+0xdc/0xf0
<c0105799> do_IRQ+0x19/0x30 <c010391a> common_interrupt+0x1a/0x20
<c0100d91> default_idle+0x41/0x70 <c0100e60> cpu_idle+0x80/0x90
<c046699d> start_kernel+0x18d/0x1d0 <c0466330> unknown_bootoption
+0x0/0x1d0
handlers:
[<c0301300>] (qs_intr+0x0/0x220)
Disabling IRQ #193
What other devices are routed to that same interrupt line?
The sata_qstor driver is very rigorous in acknowledging *only* it's own
interrupts, to prevent other devices sharing the same IRQ from losing theirs.
Mmm.. We could apply a bit of fuzzy tolerance for the odd glitch.
Try this patch (attached) and report back.
Thanks.
--- linux/drivers/scsi/sata_qstor.c.orig 2006-09-19 23:42:06.000000000 -0400
+++ linux/drivers/scsi/sata_qstor.c 2006-11-04 13:35:45.000000000 -0500
@@ -459,6 +459,7 @@
{
struct ata_host_set *host_set = dev_instance;
unsigned int handled = 0;
+ static int spurious = 0;
VPRINTK("ENTER\n");
@@ -466,6 +467,19 @@
handled = qs_intr_pkt(host_set) | qs_intr_mmio(host_set);
spin_unlock(&host_set->lock);
+ /* There are reports of at least one system with glitchy interrupts,
+ * and if we return !handled here for those then the kernel may totally
+ * disable our own IRQ line (duh!).
+ * So, try and be tolerant, but not *too* tolerant.
+ */
+ if (!handled) {
+ if (spurious < 10) {
+ ++spurious;
+ handled = 1;
+ }
+ } else if (spurious)
+ --spurious;
+
VPRINTK("EXIT\n");
return IRQ_RETVAL(handled);
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
