Re: Remove hotplug cpu crap from cpufreq.

[Andrew Morton <akpm@osdl.org>]

On Wed, 1 Nov 2006 15:09:52 -0800 (PST)
Linus Torvalds <torvalds@osdl.org> wrote:

> 
> 
> On Wed, 1 Nov 2006, Dave Jones wrote:
> >
> > I've had it with this stuff.  For months, we've had various warnings
> > popping up from this code (which was clearly half-baked at best when it
> > went in).
> > 
> > Until someone steps up who actually gives a damn about fixing it, can
> > we just rip this crap out so I stop getting mails from users who couldn't
> > care less about CPU hotplug anyway?
> 
> Hmm. People _have_ given a damn, and I think you were even cc'd.

I don't think Gautham cares about cpufreq-vs-hotplug per-se.  He cares
about the crappy cpufreq code and the warnings it emits.

> Did you take a look at the 5-patch (or was it 6?) series by Gautham R 
> Shenoy <ego@in.ibm.com>? I'm cc'ing him, in case you weren't on the 
> original list, and he should talk to you ;)

Gautham's work is "add lots of complex machinery so cpufreq's existing crap
works as it was supposed to".  We end up with complex machinery as well as
crappy cpufreq.

The alternative is to rip all that stuff out of cpufreq and then go back
and reimplement cpufreq cpu-hotplug safety from scratch.

> Right now, for 2.6.19, I'd prefer to not touch that mess unless there are 
> known conditions that actually cause more problems than just stupid 
> warnings..

afaik the warnings are the only symptom.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/