On Wed, 2006-11-01 at 15:29 -0800, Andrew Morton wrote: > On Wed, 01 Nov 2006 21:30:43 +1100 > Rusty Russell <[email protected]> wrote: > > > --- a/include/asm-i386/bugs.h > > +++ b/include/asm-i386/bugs.h > > @@ -21,6 +21,7 @@ > > #include <asm/processor.h> > > #include <asm/i387.h> > > #include <asm/msr.h> > > +#include <asm/paravirt.h> > > In many other places you have > > #ifdef CONFIG_PARAVIRT > #include <asm/paravirt.h> > ... > > But not here. > > Making <asm/paravirt.h> invulnerable would be the more typical approach. It *is* actually safe. The "#ifdef CONFIG_PARAVIRT / #include <asm/paravirt.h> / #else / <... native versions...>" is to give a big hint to the reader to look in paravirt.h for the real definitions. Originally I had a noparavirt.h where all these lived, and people hated it. So we did it this way, which minimizes churn. Rusty. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 0/7] x86 paravirtualization infrastructure
- From: Chris Wright <[email protected]>
- [PATCH 6/7] Add APIC accessors to paravirt-ops.
- From: Chris Wright <[email protected]>
- Re: [PATCH 6/7] Add APIC accessors to paravirt-ops.
- From: Andi Kleen <[email protected]>
- Re: [PATCH 6/7] Add APIC accessors to paravirt-ops.
- From: Rusty Russell <[email protected]>
- Re: [PATCH 6/7] Add APIC accessors to paravirt-ops.
- From: Andi Kleen <[email protected]>
- [PATCH 1/7] paravirtualization: header and stubs for paravirtualizing critical operations
- From: Rusty Russell <[email protected]>
- [PATCH 2/7] paravirtualization: Patch inline replacements for common paravirt operations.
- From: Rusty Russell <[email protected]>
- [PATCH 3/7] paravirtualization: More generic paravirtualization entry point.
- From: Rusty Russell <[email protected]>
- [PATCH 4/7] paravirtualization: Allow selected bug checks to be skipped by paravirt kernels
- From: Rusty Russell <[email protected]>
- Re: [PATCH 4/7] paravirtualization: Allow selected bug checks to be skipped by paravirt kernels
- From: Andrew Morton <[email protected]>
- [PATCH 0/7] x86 paravirtualization infrastructure
- Prev by Date: [PATCH 2/2]: Use newly defined PCI channel offline routine
- Next by Date: Re: [git patches] libata fixes
- Previous by thread: Re: [PATCH 4/7] paravirtualization: Allow selected bug checks to be skipped by paravirt kernels
- Next by thread: Re: [PATCH 2/7] paravirtualization: Patch inline replacements for common paravirt operations.
- Index(es):
 |