Re: [PATCH 4/7] paravirtualization: Allow selected bug checks to be skipped by paravirt kernels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew Morton wrote:
On Wed, 01 Nov 2006 21:30:43 +1100
Rusty Russell <[email protected]> wrote:

--- a/include/asm-i386/bugs.h
+++ b/include/asm-i386/bugs.h
@@ -21,6 +21,7 @@
 #include <asm/processor.h>
 #include <asm/i387.h>
 #include <asm/msr.h>
+#include <asm/paravirt.h>

In many other places you have

#ifdef CONFIG_PARAVIRT
#include <asm/paravirt.h>
...

But not here.

Making <asm/paravirt.h> invulnerable would be the more typical approach.
CONFIG_PARAVIRT is not being used to guard asm/paravirt.h from multiple inclusion. In places where it is being used to guard #include <asm/paravirt.h>, the idea is that asm/paravirt.h defines various inlines/macros which would otherwise be defined in the header. So, for example, asm/desc.h would normally define load_gdt() in the !CONFIG_PARAVIRT case, but asm/paravirt.h defines it when CONFIG_PARAVIRT is enabled. In this case, asm/paravirt.h included because we need the definition for paravirt_enabled(), not because it is replacing any of bugs.h's definitions.

   J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux