Re: [PATCH] appletalk: prevent unregister_sysctl_table() with a NULL argument

On Tue, 24 Oct 2006, Akinobu Mita wrote:

> If register_sysctl_table() fails during module initalization,
> NULL pointer dereference will happen in the module cleanup.
> 

The only way this would happen at atalk_unregister_sysctl is if the 
kmalloc failed on register_sysctl_table during init.  In that case there 
is no need to unregister atalk in the first place since it never came up, 
so this doesn't appear to be the correct fix.  Even if it were possible, 
this check should be done at atalk_exit instead of 
atalk_unregister_sysctl.

		David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] appletalk: prevent unregister_sysctl_table() with a NULL argument
  - From: Akinobu Mita <[email protected]>

References:
- [PATCH] appletalk: prevent unregister_sysctl_table() with a NULL argument
  - From: Akinobu Mita <[email protected]>

Prev by Date: Re: [RFC] commit_write less than prepared by prepare_write
Next by Date: Re: [PATCH] libata-sff: Allow for wacky systems
Previous by thread: [PATCH] appletalk: prevent unregister_sysctl_table() with a NULL argument
Next by thread: Re: [PATCH] appletalk: prevent unregister_sysctl_table() with a NULL argument
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]