[PATCH] appletalk: prevent unregister_sysctl_table() with a NULL argument

If register_sysctl_table() fails during module initalization,
NULL pointer dereference will happen in the module cleanup.

Cc: Arnaldo Carvalho de Melo <[email protected]>
Signed-off-by: Akinobu Mita <[email protected]>

 net/appletalk/sysctl_net_atalk.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: work-fault-inject/net/appletalk/sysctl_net_atalk.c
===================================================================
--- work-fault-inject.orig/net/appletalk/sysctl_net_atalk.c
+++ work-fault-inject/net/appletalk/sysctl_net_atalk.c
@@ -78,5 +78,6 @@ void atalk_register_sysctl(void)
 
 void atalk_unregister_sysctl(void)
 {
-	unregister_sysctl_table(atalk_table_header);
+	if (atalk_table_header)
+		unregister_sysctl_table(atalk_table_header);
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] appletalk: prevent unregister_sysctl_table() with a NULL argument
    • From: Alexey Dobriyan <[email protected]>
  • Re: [PATCH] appletalk: prevent unregister_sysctl_table() with a NULL argument
    • From: David Rientjes <[email protected]>

• Prev by Date: Re: [PATCH] Use extents for recording what swap is allocated.
• Next by Date: [PATCH] edac_mc: fix error handling
• Previous by thread: [Fwd: Re: More uml build failures on 2.16.19-rc3 and 2.6.18.1]
• Next by thread: Re: [PATCH] appletalk: prevent unregister_sysctl_table() with a NULL argument
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]