On Sat, Oct 21, 2006 at 08:11:56PM +0200, Andi Kleen wrote:
>
> > > - if (nmi_watchdog == NMI_DEFAULT && dmi_get_year(DMI_BIOS_DATE) >= 2004)
> > > + Probably safe on most older systems too, but let's be careful.
> > > + IBM ThinkPads use INT10 inside SMM and that allows early NMI inside SMM
> > > + which hangs the system. Disable watchdog for all thinkpads */
> > > + if (nmi_watchdog == NMI_DEFAULT && dmi_get_year(DMI_BIOS_DATE) >= 2004 &&
> > > + !dmi_name_in_vendors("ThinkPad"))
> > > nmi_watchdog = NMI_LOCAL_APIC;
> >
> > This is going to get some people scratching their heads wondering
> > why it isn't working if they ever try nmi_watchdog on one of these.
> > How about adding an explanitory printk ?
>
> When you enable it manually then NMI_DEFAULT won't be set and this code
> is never executed.
>
> BTW their machines will likely not stay up long enough that they can
> see the printk (unless Lenovo fixes that particular bug in the future,
> they are aware of it)
Ouch, nasty. I'm surprised no-one complained about this earlier.
Dave
--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
