Re: [PATCH] [11/19] i386: Fix fake return address

[Jeremy Fitzhardinge <jeremy@goop.org>]

Andi Kleen wrote:
> From: Jeremy Fitzhardinge <jeremy@goop.org>
> The fake return address was being set to __KERNEL_PDA, rather than 0.
> Push it earlier while %eax still equals 0.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
> Signed-off-by: Andi Kleen <ak@suse.de>
> Cc: Andi Kleen <ak@muc.de>
> Cc: Andrew Morton <akpm@osdl.org>
>
> ---
>  arch/i386/kernel/head.S |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/arch/i386/kernel/head.S
> ===================================================================
> --- linux.orig/arch/i386/kernel/head.S
> +++ linux/arch/i386/kernel/head.S
> @@ -317,7 +317,7 @@ is386:	movl $2,%ecx		# set MP
>  	movl %eax,%gs
>  	lldt %ax
>  	cld			# gcc2 wants the direction flag cleared at all times
> -	pushl %eax		# fake return address
> +	pushl $0		# fake return address for unwinder
>  #ifdef CONFIG_SMP
Yep, that's better than my patch, but the comment is out of date.

   J

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/