Re: [PATCH] Minor fixes to generic do_div

On Thu, 19 Oct 2006 21:34:00 -0600
Matthew Wilcox <[email protected]> wrote:

> +/* The unnecessary pointer compare is there
> + * to check for type safety (n must be 64bit)
> + */
> +# define do_div(n,base) ({				\
> +	uint32_t __base = (base);			\
> +	uint32_t __rem;					\
> +	(void)(((typeof((n)) *)0) == ((uint64_t *)0));	\
> +	__rem = ((uint64_t)(n)) % __base;		\
> +	(n) = ((uint64_t)(n)) / __base;			\
> +	__rem;						\
>   })

Can we use typecheck(), from include/linux/kernel.h?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Minor fixes to generic do_div
    • From: Matthew Wilcox <[email protected]>

• References:
  • [PATCH] Minor fixes to generic do_div
    • From: Matthew Wilcox <[email protected]>

• Prev by Date: Re: [NFS] [PATCH 07/11] NFS: fix minor bug in new NFS symlink code
• Next by Date: Re: Badness in irq_create_mapping at arch/powerpc/kernel/irq.c:527
• Previous by thread: [PATCH] Minor fixes to generic do_div
• Next by thread: Re: [PATCH] Minor fixes to generic do_div
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]