Re: [NFS] [PATCH 07/11] NFS: fix minor bug in new NFS symlink code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/20/06, Andrew Morton <[email protected]> wrote:
On Thu, 19 Oct 2006 13:04:32 -0400
Trond Myklebust <[email protected]> wrote:

> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index 58d4405..c86a1ea 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -1519,8 +1519,8 @@ static int nfs_symlink(struct inode *dir
>       pagevec_init(&lru_pvec, 0);
>       if (!add_to_page_cache(page, dentry->d_inode->i_mapping, 0,
>                                                       GFP_KERNEL)) {
> -             if (!pagevec_add(&lru_pvec, page))
> -                     __pagevec_lru_add(&lru_pvec);
> +             pagevec_add(&lru_pvec, page);
> +             pagevec_lru_add(&lru_pvec);
>               SetPageUptodate(page);
>               unlock_page(page);
>       } else

One could export add_to_page_cache_lru() to modules..

I assumed there was probably a good reason that this had not already been done.

--
"We who cut mere stones must always be envisioning cathedrals"
  -- Quarry worker's creed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux