On Sat, Oct 14, 2006 at 10:55:06PM -0300, Mauro Carvalho Chehab wrote:
> Em Sáb, 2006-10-14 às 21:14 +0200, Adrian Bunk escreveu:
> > On Sat, Oct 14, 2006 at 02:57:10PM -0400, Michael Krufky wrote:
> > > Adrian Bunk wrote:
> > >
> > > Two separate problems, please do not confuse them.
> > >
> > > My tda10086 and tda826x patches are correct -- there is no question of it.
> >
> > The problem is that they don't fix the whole problem.
> Yes. Trent made two patches using your suggestion of checking for
> MODULE. I'll submit it to Linus probably tomorrow after some tests.
>
> If you want to review, they are at:
> http://linuxtv.org/hg/v4l-dvb?cmd=changeset;node=b8c06286cb3a;style=gitweb
> http://linuxtv.org/hg/v4l-dvb?cmd=changeset;node=18a778dbf540;style=gitweb
At a first glance they look good.
> > To be honest and after looking deeper at it, I don't like this
> > CONFIG_DVB_FE_CUSTOMIZE approach at all since it adds that much
> > complexity for not much gain.
> Yes, it adds some complexity. The gain, however, is to allow having
> smaller kernel size on embedded systems and DVR using MythTV or Freevo.
> There's a similar feature for V4L (Autoselect pertinent
> encoders/decoders and other helper chips), that allows selecting just
> the needed stuff.
I understand this, but I still don't like the solution.
But unless I can send a patch with a better solution, this is nothing I
can complain about...
There are two things that might be changed even now:
The "default m if DVB_FE_CUSTOMISE" is something I do not like that
much, especially considering that embedded users caring about kernel
size are likely to use CONFIG_MODULES=n.
Another thing is that we might want to let DVB_FE_CUSTOMISE depend on
EMBEDDED - for the average non-embedded user kernel size doesn't matter
that much, and CONFIG_DVB_FE_CUSTOMIZE=y might often cause user
confusion (similar to e.g. KEYBOARD_ATKBD depending on EMBEDDED,
although many users might use USB keyboards).
> > I'd simply select all frontends unconditionally
> Most users do this, including me :)
>
> Cheers,
> Mauro.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
