Re: [PATCH 08/18] V4L/DVB (4734): Tda826x: fix frontend selection for dvb_attach

[Michael Krufky <mkrufky@linuxtv.org>]

Adrian Bunk wrote:

> On Sat, Oct 14, 2006 at 02:10:33PM -0400, Michael Krufky wrote:
>  
>
> > > This breaks with CONFIG_VIDEO_SAA7134_DVB=y, CONFIG_DVB_TDA826X=m.
> > >      
> > Regardless, the patch must be applied.  The above should only break with DVB_FE_CUSTOMIZE=Y ...
> >
> > Turn off DVB_FE_CUSTOMIZE, and you will find that the above does NOT break.  You can probably reproduce this 'broken' situation by setting any card driver = y, with the frontend = m ...
> >
> > As stated in the prior thread, "CONFIG_VIDEO_SAA7134_DVB=y, CONFIG_DVB_TDA826X=m" is not the problem -- rather, "CONFIG_VIDEO_SAA7134_DVB=y, CONFIG_DVB_TDA826X=m, DVB_FE_CUSTOMIZE=Y" causes the breakage.
> >    
> This patch fixes only a part of the problem.
>
> If this is the way how you want to handle CONFIG_DVB_FE_CUSTOMIZE=y, 
> I don't understand why you don't use
>  #if defined(CONFIG_DVB_TDA826X) || (defined(CONFIG_DVB_TDA826X_MODULE) && defined(MODULE))
> which is what I stated in exactly the thread you quote.
>  
Adrian --

Two separate problems, please do not confuse them.

My tda10086 and tda826x patches are correct -- there is no question of it.

I did not get an email from you with a suggestion for a fix for 
DVB_FE_CUSTOMIZE, but my cable / internet has been down for a day and a 
half, maybe it will come in soon.

I am not the author of DVB_FE_CUSTOMIZE, adq (cc added) seems to be busy 
at the moment.  Please send in your patch suggestion to the 
v4l-dvb-maintainer list, if you haven't already, and we can discuss that 
issue separately.

-Mike Krufky

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/