Burman Yan <[email protected]> ha scritto:
> I would like to hear your remarks on this version.
A couple of small issues:
> +/* Sysfs stuff */
> +static ssize_t mdps_position_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + int x, y;
> + mdps_get_xy(mdps.device->handle, &x, &y);
> + return sprintf(buf, "(%d, %d)\n", x, y);
> +}
hdaps doesn't have the space between the numbers.
> +static ssize_t mdps_position3d_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
[...]
> + return sprintf(buf, "(%d, %d, %d)\n", x, y, z);
> +}
I'd also remove the space here for consistency.
Also sysfs should carry "unformatted" data, I would use:
sprintf(buf, "%d %d %d\n", x, y, z);
Maybe we should take a moment to think about an interface for both hdaps
and this one.
> +static ssize_t mdps_calibrate_store(struct device *dev,
> + struct device_attribute *attr, const char *buf, size_t count)
> +{
> + mdps_calibrate_mouse();
> + return count;
> +}
No locking here?
> +static ssize_t mdps_rate_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
[...]
> + return sprintf(buf, "sampling rate:\t%dHz\n", rate);
> +}
Raw value, i.e. sprintf(buf, "%d\n", rate).
Luca
--
Colui che sorride quando le cose vanno male ha pensato a qualcuno a cui
dare la colpa.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
