Re: [PATCH] fix parport_serial_pci_resume() ignoring return value from pci_enable_device()

On Fri, 13 Oct 2006, Russell King wrote:

> I suspect all these kind of patches are introducing additional problems.
> This one certainly is.  Who's auditing all these patches?  I mean _properly_
> auditing them rather than just saying "that's a good idea"?

For the fm801 gameport case it is fine - it's just one more check in the 
_probe() function, performing the same error path as other cases do.

ALSA case has already been solved by calling snd_card_disconnect() on 
error path.

But I agree that sk98lin and parport_serial_pci patches are likely broken.

Thanks,

-- 
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] fix parport_serial_pci_resume() ignoring return value from pci_enable_device()
    • From: Jiri Kosina <[email protected]>
  • Re: [PATCH] fix parport_serial_pci_resume() ignoring return value from pci_enable_device()
    • From: Russell King <[email protected]>

• Prev by Date: [PATCH 2.6.19-rc1 full] drivers: add LCD support
• Next by Date: Re: [PATCH] sk98lin: handle pci_enable_device() return value in skge_resume() properly
• Previous by thread: Re: [PATCH] fix parport_serial_pci_resume() ignoring return value from pci_enable_device()
• Next by thread: Why aren't partitions limited to fit within the device?
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]