Re: [PATCH] fix parport_serial_pci_resume() ignoring return value from pci_enable_device()

On Fri, 13 Oct 2006, Russell King wrote:

> In this case, you're calling parport_serial_pci_remove() in the failure 
> path.  That's fine, but this opens the possibility of it being called 
> twice - once on resume failure and once when the device/driver is 
> removed.  If this happens, we dereference a NULL pointer. *BAD*.

You are right, I missed this.

I am not currently sure what the proper fix is, though. We might be also 
ending doing very bad things, when we ignore the error returned by 
pci_enable_device() and proceed operating on non-existing device.

Thanks for spotting this,

-- 
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] fix parport_serial_pci_resume() ignoring return value from pci_enable_device()
    • From: Jiri Kosina <[email protected]>
  • Re: [PATCH] fix parport_serial_pci_resume() ignoring return value from pci_enable_device()
    • From: Russell King <[email protected]>

• Prev by Date: Re: [ckrm-tech] [PATCH 0/5] Allow more than PAGESIZE data read in configfs
• Next by Date: Re: [patch] rearrange kioctx and aio_ring_info
• Previous by thread: Re: [PATCH] fix parport_serial_pci_resume() ignoring return value from pci_enable_device()
• Next by thread: Re: [PATCH] fix parport_serial_pci_resume() ignoring return value from pci_enable_device()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]