funny looking equation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I was just testing some of my parsing code on all the .c and .h files in
the Linux kernel, and I came up with this little equation:

from 2.6.18 drivers/atm/eni.c:1272


---
                        int div;

                        if (!*pcr) *pcr = eni_dev->tx_bw+reserved;
                        for (*pre = 3; *pre >= 0; (*pre)--)
                                if (TS_CLOCK/pre_div[*pre]/64 > -*pcr) break;
                        if (*pre < 3) (*pre)++; /* else fail later */
                        div = pre_div[*pre]*-*pcr;
                                    ^^^^^^^^^^^^^
    This could really do with some spaces and a couple of parenthesis.

                        DPRINTK("max div %d\n",div);
                        *res = (TS_CLOCK+div-1)/div-1;
---


Oh well, this isn't a bug.  Just something that someone might want to
clean up the next time they touch that code.

-- Steve


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux