Re: [PATCH] preserve correct battery state through suspend/resume cycles

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > > > echo "platform" > /sys/power/disk
> > > > echo "disk" > /sys/power/state
> > > 
> > > Maybe we should change the default in 2.6.20 or so?
> > 
> > Well, I think swsusp should work with "shutdown" just as well.  If it doesn't,
> > that means there are some bugs in the ACPI code which should be fixed.
> > By using "platform" as the default method we'll be hiding those bugs IMHO.
> 
> I'm not really intimately familiar with the ACPI spec, but IIRC those AML
> methods executed by pm_ops->prepare and pm_ops->finish are mandatory for
> suspending ACPI enabled machines. So using "platform" as a default
> seems

With "shutdown" we are not *suspending* machine. We are just saving
its state, and then restoring it. ACPI BIOS should not need to know.

We want both "platform" _and_ "shutdown" to work.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/