On Mon, Oct 09, 2006 at 01:58:36PM +0200, Nick Piggin wrote: > > > > > > It also needs update_mmu_cache() I suppose. > > > > > > > > > > Hmm, but it might not be called from a pagefault. Can we get away > > > > > with not calling it? Or is it required by some architectures? > > > > > > > > I think some architectures might be upset if it's not called... > > > > > > But would any get upset if it is called from !pagefault path? > > > > Probably not... the PTE has been filled so it should be safe, but then, > > I don't know the details of what non-ppc archs do with that callback. I guess we can make the rule that it only be called from the ->fault handler anyway. If they want that functionality from ->mmap, then they can use remap_pfn_range, because it isn't so performance critical. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [patch 3/3] mm: fault handler to replace nopage and populate
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [patch 3/3] mm: fault handler to replace nopage and populate
- References:
- Re: [patch 3/3] mm: fault handler to replace nopage and populate
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [patch 3/3] mm: fault handler to replace nopage and populate
- From: Nick Piggin <[email protected]>
- Re: [patch 3/3] mm: fault handler to replace nopage and populate
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [patch 3/3] mm: fault handler to replace nopage and populate
- From: Nick Piggin <[email protected]>
- Re: [patch 3/3] mm: fault handler to replace nopage and populate
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [patch 3/3] mm: fault handler to replace nopage and populate
- From: Nick Piggin <[email protected]>
- Re: [patch 3/3] mm: fault handler to replace nopage and populate
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [patch 3/3] mm: fault handler to replace nopage and populate
- From: Nick Piggin <[email protected]>
- Re: [patch 3/3] mm: fault handler to replace nopage and populate
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [patch 3/3] mm: fault handler to replace nopage and populate
- From: Nick Piggin <[email protected]>
- Re: [patch 3/3] mm: fault handler to replace nopage and populate
- Prev by Date: Re: [patch 3/3] mm: fault handler to replace nopage and populate
- Next by Date: Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4]
- Previous by thread: Re: [patch 3/3] mm: fault handler to replace nopage and populate
- Next by thread: Re: [patch 3/3] mm: fault handler to replace nopage and populate
- Index(es):
 |