Re: + clocksource-increase-initcall-priority.patch added to -mm tree

[Thomas Gleixner <tglx@linutronix.de>]

On Sun, 2006-10-08 at 10:17 -0700, Daniel Walker wrote:
> There was a special case inside kernel/time/clocksource.c to prevent
> clock switching during boot up. If you remove that (which I have) then
> you will end up with clock switching happening a few times during bootup
> (whenever a new highest rated clock is registered), that's the churn I'm
> referring to.
> 
> The churn is not optimal. I've used postcore to prevent it, and make the
> API usable earlier. So there is a reason for the change. 

Yes, a bad one. The disabling had a totally different reason and you are
not listening at all.

You just introduce a problem again, because it does not happen on your
machines and you think, that some not yet available instrumentation code
needs high resolution time stamps. 

The reason why this was delayed into late boot is simply that the
unstable, unsynchronized TSC's made way too much trouble and the pmtimer
can not be initialized early.

I'm not going to accept that. Your change might work on 5 machines you
have tested on, but we start over with the same breakage we solved
already. 

This early boot instrumentation code can work with low resolution time
information quite well and none of the boot code does need any high res
time information. Boot code is different from a running system and has
different requirements. 

This is a solution for a nonexisting problem, which just brings back
already solved ones.

	tglx



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/