Re: [PATCH, RAW] IRQ: Maintain irq number globally rather than passing to IRQ handlers

On Fri, 6 Oct 2006, Dmitry Torokhov wrote:
> 
> But drivers rarely care about exact IRQ that caused their interrupt
> routines to be called.

Sure. But it's not a _cleanup_ as far as I can tell.

> Drivers that truly need to know IRQ can have it added to dev_id cookie
> and use separate dev_ids.

I'm not saying that what you describe is impossible. I'm just saying that 
it's pointless. 

What's wrong with passing in "irq"? It makes sense from a logical angle, 
and it's something you kind of expect if you think of irq's as "signals 
for the kernel" (which they almost literally used to be, why do you think 
it was called "SA_SHIRQ" etc?).

So there is absolutely nothing wrong with passing in irq from a conceptual 
or a practical angle, and some routines _do_ use it.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
    • From: David Howells <[email protected]>
  • Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
    • From: Alan Cox <[email protected]>
  • Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
    • From: Jeff Garzik <[email protected]>
  • [PATCH, RAW] IRQ: Maintain irq number globally rather than passing to IRQ handlers
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH, RAW] IRQ: Maintain irq number globally rather than passing to IRQ handlers
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH, RAW] IRQ: Maintain irq number globally rather than passing to IRQ handlers
    • From: "Dmitry Torokhov" <[email protected]>

• Prev by Date: Re: [PATCH] [PATCH] Rename pdc_init
• Next by Date: [announce] kdump2gdb: analyze kdumps with gdb (well, almost)
• Previous by thread: Re: [PATCH, RAW] IRQ: Maintain irq number globally rather than passing to IRQ handlers
• Next by thread: Re: [PATCH, RAW] IRQ: Maintain irq number globally rather than passing to IRQ handlers
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]