On 10/6/06, Linus Torvalds <[email protected]> wrote:
In contrast, the irq argument itself is really no different from the cookie we pass in on registration - it's just passing it back to the driver that requested the thing. So unlike "regs", there's not really anything strange about it, and there's nothing really "wrong" with having it there. So I'm not at all as convinced about this one.
But drivers rarely care about exact IRQ that caused their interrupt routines to be called. I looked at some of them and they normally use it just to print warnings which is not critical (and data can still be retrieved form elsewhere). And without it the only argument can very nicely be passed via a register (if regparm is allowed). Drivers that truly need to know IRQ can have it added to dev_id cookie and use separate dev_ids. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
- From: Andrew Morton <[email protected]>
- Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
- From: David Howells <[email protected]>
- Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
- From: Jeff Garzik <[email protected]>
- Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
- From: Alan Cox <[email protected]>
- Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
- From: Jeff Garzik <[email protected]>
- Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
- From: Ingo Molnar <[email protected]>
- Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
- From: Jeff Garzik <[email protected]>
- [PATCH, RAW] IRQ: Maintain irq number globally rather than passing to IRQ handlers
- From: Jeff Garzik <[email protected]>
- Re: [PATCH, RAW] IRQ: Maintain irq number globally rather than passing to IRQ handlers
- From: Linus Torvalds <[email protected]>
- Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
- Prev by Date: [PATCH] [PATCH] Rename pdc_init
- Next by Date: Re: 2.6.19-rc1 genirq causes either boot hang or "do_IRQ: cannot handle IRQ -1"
- Previous by thread: Re: [PATCH, RAW] IRQ: Maintain irq number globally rather than passing to IRQ handlers
- Next by thread: Re: [PATCH, RAW] IRQ: Maintain irq number globally rather than passing to IRQ handlers
- Index(es):
 |