Re: [RFC] PATCH to fix rescan_partitions to return errors properly

[Erik Mouw <erik@harddisk-recovery.com>]

On Wed, Oct 04, 2006 at 09:50:51AM -0700, Suzuki Kp wrote:
> Erik Mouw wrote:
> >On Tue, Oct 03, 2006 at 06:00:36PM -0700, Suzuki Kp wrote:
> >
> >>Currently the rescan_partition returns 0 (success), even if it is unable
> >>to rescan the partition information ( may be due to disks offline, I/O
> >>error reading the table or unknown partition ). This would make ioctl()
> >>calls succeed for BLKRRPART requests even if partitions were not scanned
> >>properly, which is not a good thing to do.
> >>
> >>Attached here is patch to fix the issue. The patch makes
> >>rescan_partition to return -EINVAL for unknown partitions and -EIO for
> >>disk I/O errors ( or when disks are offline ).
> >
> >I don't think it's a good idea to return an error when there's an
> >unknown partition table. How do you differentiate between a device that
> >isn't partitioned at all and a device with an unknown partition table?
> 
> Returning -EINVAL in both the above cases would inform the user that, 
> the partition table was not read properly due to an invalid arguemnt 
> (the disk) passed, which holds good for both the above cases.
> 
> What do you think ?

I disagree. It's perfectly valid for a disk not to have a partition
table (for example: components of a RAID5 MD device) and we shouldn't
scare users about that. Also an unrecognised partition table format
(DEC VMS, Novell Netware, etc.) is not a reason to throw an error, it's
just unrecognised and as far as the kernel knows it's unpartioned.

It's OK to tell the user that there was some kind of device error when
scanning the partition table but IMHO an unpartitioned disk is not a
device error.


Erik

-- 
+-- Erik Mouw -- www.harddisk-recovery.com -- +31 70 370 12 90 --
| Lab address: Delftechpark 26, 2628 XH, Delft, The Netherlands
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/