fb_find_mode() is behaving in an non-intuitive way. When I specify my
own video mode database, and no default mode, I would have expected it
to assume the first mode in my database as the default mode. Instead, it
uses the built in database:
> if (!db) {
> db = modedb;
> dbsize = ARRAY_SIZE(modedb);
> }
> if (!default_mode)
> default_mode = &modedb[DEFAULT_MODEDB_INDEX];
Personally, I think this is incorrect - if an alternate database is
specified, it should be always using that. Patch is attached.
Regards,
Jordan
--
Jordan Crouse
Senior Linux Engineer
Advanced Micro Devices, Inc.
<www.amd.com/embeddedprocessors>
[PATCH] video: Get the default mode from the right database
From: Jordan Crouse <[email protected]>
If no default mode is specified, it should be grabbed from the supplied
database, not the default one.
Signed-off-by: Jordan Crouse <[email protected]>
---
drivers/video/modedb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/modedb.c b/drivers/video/modedb.c
index d126790..e068f52 100644
--- a/drivers/video/modedb.c
+++ b/drivers/video/modedb.c
@@ -506,7 +506,7 @@ int fb_find_mode(struct fb_var_screeninf
dbsize = ARRAY_SIZE(modedb);
}
if (!default_mode)
- default_mode = &modedb[DEFAULT_MODEDB_INDEX];
+ default_mode = &db[DEFAULT_MODEDB_INDEX];
if (!default_bpp)
default_bpp = 8;
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]