Re: [PATCH] include children count, in Threads: field present in /proc/<pid>/status (take-3)

[girish <girishvg@gmail.com>]

On Sep 30, 2006, at 3:12 AM, Jan Engelhardt wrote:

> > How about this?
> >
> > buffer += sprintf(buffer, "Threads:\t%d", num_threads);
> > if (num_children)
> >                buffer += sprintf(buffer, " Children: %d Total: %d",
> > num_children, num_threads + num_children);
> > buffer += sprintf(buffer, "\n");
>
> No, this:
>
> > if (num_children)
> >                buffer += sprintf(buffer, "\nChildren: %d\nTotal: %d",
>
> the newlines are essential because then you get _one_ field of
> information for _each_ call of fgets().
>
>
>
> Jan Engelhardt
> --  

This is perfect. Here is the patch.
Thanks.

Signed-off-by: Girish V. Gulawani <girishvg@gmail.com>

--- linux-vanilla/fs/proc/array.c	2006-09-20 12:42:06.000000000 +0900
+++ linux/fs/proc/array.c	2006-09-30 03:18:28.000000000 +0900
@@ -248,6 +248,8 @@ static inline char * task_sig(struct tas
 	int num_threads = 0;
 	unsigned long qsize = 0;
 	unsigned long qlim = 0;
+	int num_children = 0;
+	struct list_head *_p;

 	sigemptyset(&pending);
 	sigemptyset(&shpending);
@@ -268,9 +270,13 @@ static inline char * task_sig(struct tas
 		qlim = p->signal->rlim[RLIMIT_SIGPENDING].rlim_cur;
 		spin_unlock_irq(&p->sighand->siglock);
 	}
+	list_for_each(_p, &p->children)
+		++num_children;
 	read_unlock(&tasklist_lock);

 	buffer += sprintf(buffer, "Threads:\t%d\n", num_threads);
+	if (num_children)
+		buffer += sprintf(buffer, "Children:\t%d\nTotal:\t%d\n",  
num_children, num_threads + num_children);
 	buffer += sprintf(buffer, "SigQ:\t%lu/%lu\n", qsize, qlim);

 	/* render them all */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/