On Sep 30, 2006, at 1:31 AM, William Pitcock wrote:
On Sep 29, 2006, at 10:18 AM, girish wrote:
- buffer += sprintf(buffer, "Threads:\t%d\n", num_threads);
+ buffer += sprintf(buffer, "Threads:\t%d\n", num_threads +
num_children);
Personally, I'd prefer the children count to be separate, something
like:
buffer += sprintf(buffer, "Threads:\t%d (%d children, %d total)",
num_threads, num_children, num_threads + num_children);
That would be rather nice, indeed.
Also, next time, make sure that linux-kernel is CC'd, not BCC'd.
---
William Pitcock
[email protected]
http://people.atheme.org/~nenolod/
http://nenolod.net
Agree. It indeed look better. I too had an awk script in mind, to
parse the line. I ended up removing such formatting, because not all
process spawn child thread(s), showing num_children count as zero.
That looked bit odd. So here it is again - new wine.
Thanks.
Signed-off-by: Girish V. Gulawani <[email protected]>
--- linux-vanilla/fs/proc/array.c 2006-09-20 12:42:06.000000000 +0900
+++ linux/fs/proc/array.c 2006-09-30 01:47:25.000000000 +0900
@@ -248,6 +248,8 @@ static inline char * task_sig(struct tas
int num_threads = 0;
unsigned long qsize = 0;
unsigned long qlim = 0;
+ int num_children = 0;
+ struct list_head *_p;
sigemptyset(&pending);
sigemptyset(&shpending);
@@ -268,9 +270,14 @@ static inline char * task_sig(struct tas
qlim = p->signal->rlim[RLIMIT_SIGPENDING].rlim_cur;
spin_unlock_irq(&p->sighand->siglock);
}
+ list_for_each(_p, &p->children)
+ ++num_children;
read_unlock(&tasklist_lock);
- buffer += sprintf(buffer, "Threads:\t%d\n", num_threads);
+ buffer += sprintf(buffer, "Threads:\t%d", num_threads);
+ if (num_children)
+ buffer += sprintf(buffer, " (%d children, %d total)",
num_children, num_threads + num_children);
+ buffer += sprintf(buffer, "\n");
buffer += sprintf(buffer, "SigQ:\t%lu/%lu\n", qsize, qlim);
/* render them all */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
